johnyangk commented on a change in pull request #178: [NEMO-317] Optimize triggering logic in GroupByKeyAndWindowDoFnTransform URL: https://github.com/apache/incubator-nemo/pull/178#discussion_r241644905
########## File path: compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/transform/GroupByKeyAndWindowDoFnTransform.java ########## @@ -52,15 +53,11 @@ private transient InMemoryStateInternalsFactory inMemoryStateInternalsFactory; private Watermark prevOutputWatermark; private final Map<K, Watermark> keyAndWatermarkHoldMap; + private final WindowingStrategy windowingStrategy; + private Watermark inputWatermark; Review comment: Remove this variable and reuse `inMemoryTimerInternalsFactory.context#currentInputWatermarkTime`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
