johnyangk commented on a change in pull request #178: [NEMO-317] Optimize
triggering logic in GroupByKeyAndWindowDoFnTransform
URL: https://github.com/apache/incubator-nemo/pull/178#discussion_r241644700
##########
File path:
compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/transform/GroupByKeyAndWindowDoFnTransform.java
##########
@@ -155,21 +153,23 @@ private void processElementsAndTriggerTimers(final
Watermark inputWatermark,
getDoFnRunner().processElement(WindowedValue.valueInGlobalWindow(keyedWorkItem));
}
- // Trigger timers
- triggerTimers(key, inputWatermark, processingTime, synchronizedTime);
+ iterator.remove();
Review comment:
👍 for clearing out the whole (key, values), and not just (values)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
