Hi, Copied from PR ...
On Thu, 11 Jul 2019 at 22:35, Josh Juneau <[email protected]> wrote: > Thanks Neil! I’ll submit the PR tonight. I appreciate it. Unfortunately this PR is broken. I've tried manually creating a patch based on your last commit and it also fails to build with the same error as in Travis ``` ... netbeans/enterprise/j2ee.dd/build.xml:341: Replace: source file ...netbeans/enterprise/j2ee.dd/src/org/netbeans/modules/j2ee/dd/impl/web/model_4_0_frag/WebFragment.java doesn't exist ``` It looks like the .gitignore file at https://github.com/apache/netbeans/blob/master/enterprise/j2ee.dd/.gitignore needs updating for the newly generated files too. I think you're going to have to reset your fork (or delete and create a new fork), keep master clean and in sync, apply these changes in a PR-specific branch, check it builds, and resubmit the PR. Let me know if that's feasible today and I'll hold off beta4 build. Thanks! --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
