Some comments inlined below
El 16/7/19 a las 1:36, Michał Dymecki escribió:
I'm that "someone else" - author of the PR.
You say that "If it ain't broke, don't fix it...". The problem is, it is
broke and even the source code says it itself:
// @TODO - source maps not currently working
https://github.com/apache/netbeans-website/blame/a808570c4425c11fa490573f97307325f73a2646/netbeans.apache.org/build.gradle#L49
Also the full Foundation framework is used and now it generates 131kb
css file (!). And that mess cannot be debugged without source maps:
https://github.com/apache/netbeans-website/blame/a808570c4425c11fa490573f97307325f73a2646/netbeans.apache.org/src/content/scss/netbeans.scss#L28
Neil and Antonio commited that not working code into the repository, now
they want to close the PR that fixes their code, and when Chris wants to
The PR won't fix anything. On the contrary: it will break everything.
It will break the current jenkins jobs, for instance. So we'll need
"someone else" to decide which node/npm versions are required, and then
we'll need "someone else" to set-up the jenkins jobs to download several
hundred megabytes (node + npm + dependencies) just to add support for
source maps. And then we'll need "someone else" to maintain the
resulting build system.
What's being said in the PR, and in the mailing list, is that the effort
would pay off if we can get rid of gradle. This is, the PR is in the
right direction (and appreciated) but falls short in extent.
Adding node (8, 10, 12?) and npm (which version?) and third-party
dependencies (open versions? non-reproducible builds?) is adding too
much complexity to the build system (and to everybody's laptops). The
build system will be so complex that the current "someone else's" we
have in the Team won't be able to put up with it.
they want to close the PR that fixes their code, and when Chris wants to > help
with fixing it too, he's being disrespected. Did I miss something?
I don't think Chris is being disrespected in any way. On the contrary,
Neil and Eric and Geertjan and Wade and Emilian and Junichi and other
contributors (including Antonio) that have built the website are being
disrespected by people that just complain about the current status of
affairs from their comfortable sofas without proposing _working_
alternatives.
The big power of Apache Projects and Communities is that if you don't
like something you're free to propose new _working_ ways of doing things
(as you have done). Complaining in the mailing lists expecting that
"someone else" do something you can do yourself is not the way to go, I
think. Nor is trying to force committers to merge PRs that will add more
mainteinance effort and reduce little their spare time.
So thank you for your PR, Michał, really. We'll try to find "someone
else" in the future to allocate some of their spare time to replace
gradle with node+npm support for the _whole_ website build system,
including the jenkins jobs.
Meanwhile we'll use our shrinking spare time in migrating content to
Apache repositories, before the Oracle servers are out of service and
content is lost forever, even though we have to go without source maps
one additional year.
Kind regards,
Antonio
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
