I will test the PR and do as you suggest Pete.

El mié., 6 nov. 2019 a las 14:56, Peter Hull (<peterhul...@gmail.com>)
escribió:

> On Wed, 6 Nov 2019 at 20:38, Svata Dedic <svatopluk.de...@gmail.com>
> wrote:
> > Yes, that was it. You probably didn't do "ant clean" (neither did I).
> Right.
> > The NPE should be fixed by
> > https://github.com/pepness/incubator-netbeans/pull/2
> Right again!
>
> I just opened up my mail to post my progress, great to see you'd
> already solved it!
>
> However:
> 1. Would it be better to jump straight to the latest Asm (7.2) - i.e.
> put in a PR against Jose's  asm72 branch
> 2. There is a also a commit titled "Add logging" on that branch, and
> the asm72 branch, which is certainly not wanted.
>
> So maybe Jose can pull yours, rebase and then put in a PR against
> apache/netbeans?
>
> Pete
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
> For additional commands, e-mail: dev-h...@netbeans.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
>

Reply via email to