On Tue, 12 May 2020 at 14:17, Geertjan Wielenga <[email protected]> wrote: > It sounds like this nb-javac/javafx dialog is showing up in undesired > places.
I made a minimal PR at https://github.com/apache/netbeans/pull/2135 This would stop the immediate issue of the dialog not being cancellable, but still isn't ideal, causes regressions elsewhere and is not uncontroversial! :-) Any thoughts on the right approach for 12.0 this late in?! IMO, we should never have allowed JavaFX to become required rather than recommended for Java enablement in 11.3. Seems borderline against ASF rules to me. The addition in 11.3 for the above has the unfortunate side effect of forcing nb-javac installation in a lot of scenarios, and given that won't support Java 14 and other things have gone in to stop it being recommended when running on Java 14, this negates all of that. I don't know if others agree this is a blocker, and it's up to Eric in the end, but I would personally certainly -1 the release with this behaviour as is. Best wishes, Neil --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
