On Fri, 18 Sep 2020 at 22:56, Eirik Bakke <eba...@ultorg.com> wrote: > > > Some time ago I wanted to add an API that allowed for pluggable service > > providers for image and text branding resolution. This would also allow > > for platform apps to do things they can't currently do. The suggestion got > > a -1 so I didn't pursue as far as code - it was in discussion around > > another PR. > > Sounds reasonable. What was the objection here? > > (I recall that this didn't end up being part of the SVGLoader ServiceProvider > interface, but that was just for technical reasons, not because of a general > objection to having a system for plugging in other icon sets.)
That discussion predated the SVGLoader discussion. There were a few things, including a concern about referential transparency - I don't see an issue with specifying the implementation(s) must return the same value for the same inputs. With text it's currently impossible to hook in and eg. change how input arguments are converted to strings. With icons there's currently too much of an assumption that these are always backed by individual files, which makes alternative icon provision by eg. font icons difficult. Well, you can do some hacks with custom ButtonActionConnectors but it's far from ideal. For a platform that provides so much power to extend and customize, I find this quite a basic omission, that hampers platform developers and the IDE. Best wishes, Neil --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
