Well, let's circulate this one for a while and see what others can add
to this one.
A system property that can change how the system works is an API (SPI),
so this one as well. It seems to be harmless, but at least needs to be
documented.
I can be convinced, my opinion on this PR in the current form is -0,
with documentation +0
If you can get some community support behind that, then I'd merge.
On 10/24/20 4:47 PM, Ernie Rael wrote:
I wasn't under the impression that adding a client property to a
JComponent is considered API. Is this a new/extended definition of API?
And yes, it's probably it would only be used by jVi. It is a
workaround for a bug in NetBeans, which I'm not sure what the
underlying problem is and how to fix it.
Exposing it in "an other way" would in fact be and API change.
To expose it, I suppose a new method on ExtCaret for the MinWidth
might work. Having that still wouldn't fix the NetBeans bug, but it
would give jVi something to use.
But I'd rather not put hacks and workarounds into the API.
-ernie
On 10/24/2020 2:14 PM, Laszlo Kishalmi wrote:
Well, I'm sorry Ernie, I appreciate your work, but in this form I
won't even let it into master.
This one is a hidden API change, I'd rather have it properly
documented and maybe expose the implementation in an other way than a
client property on a component.
The HACK_CARET_MIN_WIDTH is never used so far in the NetBeans source
code, so it must be something new and probably provided an
implementation for it in a plugin of yours.
On 10/24/20 1:30 PM, Ernie Rael wrote:
Hi all,
This is a "zero risk" patch for
https://issues.apache.org/jira/browse/NETBEANS-4940.
Is there a chance it can find its way into 12.2?
-ernie
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
