On 10/24/2020 7:13 PM, Laszlo Kishalmi wrote:
Well, let's circulate this one for a while and see what others can add to this one.

A system property that can change how the system works is an API (SPI), so this one as well. It seems to be harmless, but at least needs to be documented.

I can be convinced, my opinion on this PR in the current form is -0, with documentation +0

If you can get some community support behind that, then I'd merge.


The most technically interesting thing I found out is that editor.lib's BaseCaret, which this PR tweaks, is *no longer used in NetBeans*. Apparently it's superseded by editor.lib2's EditorCaret; which also has the drawing glitch (commentary to the contrary).

And I was wrong about the change being considered an API; it's just not a signature API, my bad. So it's documented in the fashion of a ClientProperty.

I'm not sure what to make of this PR's comment process. The PR was blocked asking for changes, and after a vigorous discussion (mostly dealing with miss-information), no change was requested, it just ended with no responses.

I've been looking for a workaround. My latest attempt is a suitable Halloween nightmare involving maven, ant, yenta, and a NoClassDefFoundError.

-ernie


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



Reply via email to