I missed a java-hint reference in the "project.xml" file which referenced it. This appears to resolve the check issues.
However now I have a "Travis CI" issue showing like the below (see https://travis-ci.com/github/apache/netbeans/jobs/496100592 ). Not sure what is causing this now. I thought I'd seen an empty test "hints" folder on my local development environment somewhere under here (netbeans\ide\db.sql.editor\test\unit\src\org\netbeans\modules\db\sql\editor\) which I removed locally but I don't see it elsewhere (nor does the "deleted" folder seem to get noticed in Netbeans git when I check for changes...unless I'm completely missing it, I don't see that as part of the PR or recent commits currently. BUILD FAILED 12419/home/travis/build/apache/netbeans/nbbuild/templates/common.xml:724: The following error occurred while executing this line: 12420/home/travis/build/apache/netbeans/nbbuild/templates/common.xml:717: The following error occurred while executing this line: 12421/home/travis/build/apache/netbeans/nbbuild/templates/common.xml:751: The following error occurred while executing this line: 12422/home/travis/build/apache/netbeans/nbbuild/templates/common.xml:748: Some tests failed; see details above. 12423 12424Total time: 26 minutes 38 seconds 12425The command "ant $OPTS -Dtest.config=batch2-vanilla-javac -f java/java.hints test" exited with 1. cache.2 12426store build cache 124270.00s1.96snothing changed Eric Bresie [email protected] On Sun, Apr 4, 2021 at 9:20 AM Eric Bresie <[email protected]> wrote: > Opps...meant 12.4-Beta2 (if and when it might happen) and/or 12.5 > > I did want to reach out regarding the CI build based on the PR updates. > > The Windows job is success but I seem to be getting some issues with some > of the other Unix platforms and checks like for “ Linux build of PHP > cluster” like the below. > > I don’t recall changing anything around this so I’m assuming either I > missed something (maybe in sql editor context there is something > implemented against a deprecated spi.java.queries interface) or there is > some ongoing change elsewhere impacting this. > > Anyone have any thoughts or suggestions? > > > [parseprojectxml] > /home/runner/work/netbeans/netbeans/java/java.source.base/test/unit/src/org/netbeans/modules/java/source/save/FormatingTest.java:22: > warning: [deprecation] SourceLevelQueryImplementation in > org.netbeans.spi.java.queries has been deprecated > 7683 > <https://github.com/apache/netbeans/pull/2820/checks?check_run_id=2260507762#step:8:7683>[parseprojectxml] > import org.netbeans.spi.java.queries.SourceLevelQueryImplementation; > 7684 > <https://github.com/apache/netbeans/pull/2820/checks?check_run_id=2260507762#step:8:7684>[parseprojectxml] > ^ > 7685 > <https://github.com/apache/netbeans/pull/2820/checks?check_run_id=2260507762#step:8:7685>[parseprojectxml] > /home/runner/work/netbeans/netbeans/java/java.source.base/test/unit/src/org/netbeans/modules/java/source/save/FormatingTest.java:48: > error: cannot find symbol > 7686 > <https://github.com/apache/netbeans/pull/2820/checks?check_run_id=2260507762#step:8:7686>[parseprojectxml] > import org.netbeans.modules.java.JavaDataLoader; > 7687 > <https://github.com/apache/netbeans/pull/2820/checks?check_run_id=2260507762#step:8:7687>[parseprojectxml] > ^ > 7688 > <https://github.com/apache/netbeans/pull/2820/checks?check_run_id=2260507762#step:8:7688>[parseprojectxml] > symbol: class JavaDataLoader > 7689 > <https://github.com/apache/netbeans/pull/2820/checks?check_run_id=2260507762#step:8:7689>[parseprojectxml] > location: package org.netbeans.modules.java > 7690 > <https://github.com/apache/netbeans/pull/2820/checks?check_run_id=2260507762#step:8:7690> > 7691 > <https://github.com/apache/netbeans/pull/2820/checks?check_run_id=2260507762#step:8:7691>BUILD > FAILED > 7692 > <https://github.com/apache/netbeans/pull/2820/checks?check_run_id=2260507762#step:8:7692>/home/runner/work/netbeans/netbeans/nbbuild/templates/projectized.xml:148: > The following error occurred while executing this line: > 7693 > <https://github.com/apache/netbeans/pull/2820/checks?check_run_id=2260507762#step:8:7693>/home/runner/work/netbeans/netbeans/nbbuild/templates/projectized.xml:148: > The following error occurred while executing this line: > 7694 > <https://github.com/apache/netbeans/pull/2820/checks?check_run_id=2260507762#step:8:7694>/home/runner/work/netbeans/netbeans/nbbuild/templates/projectized.xml:148: > The following error occurred while executing this line: > 7695 > <https://github.com/apache/netbeans/pull/2820/checks?check_run_id=2260507762#step:8:7695>/home/runner/work/netbeans/netbeans/nbbuild/templates/common.xml:652: > The following error occurred while executing this line: > 7696 > <https://github.com/apache/netbeans/pull/2820/checks?check_run_id=2260507762#step:8:7696>/home/runner/work/netbeans/netbeans/nbbuild/templates/common.xml:630: > Compile failed; see the compiler error output for details. > 7697 > <https://github.com/apache/netbeans/pull/2820/checks?check_run_id=2260507762#step:8:7697> > 7698 > <https://github.com/apache/netbeans/pull/2820/checks?check_run_id=2260507762#step:8:7698>Total > time: 28 seconds > 7699 > <https://github.com/apache/netbeans/pull/2820/checks?check_run_id=2260507762#step:8:7699>[parseprojectxml] > 13 errors > > On Sat, Apr 3, 2021 at 10:37 AM Eric Bresie <[email protected]> wrote: > >> I've checked in additional updates on this PR based on feedback from the >> PR comments. >> - I've removed the "Annotation" which prevents the need for the java icon >> referenced >> - I've removed commented code (unless I've missed any still) >> - I've addressed the case for select * from | concern >> >> I believe I've addressed most concerns, but wanted confirmation. >> >> Please review and see if this is better and getting closer for eventual >> inclusions (not sure if this is 12.3 beta2 or 12.4 candidate). >> >> >> >> Eric Bresie >> [email protected] >> >> >> On Sat, Mar 20, 2021 at 1:30 PM Eric Bresie <[email protected]> wrote: >> >>> This is in regards to NETBEANS-189 SQL editor, shouldn't ask every time >>> to set the connection. >>> >>> I have created a pull request for updates relating to >>> https://github.com/apache/netbeans/pull/2820 >>> >>> This allows autocompletion to occur even if a connection has not been >>> set. It adds some "hints" to resolve potential issues. The previous >>> "dialog" no longer opens up any more but is still available when selecting >>> the "Connect to Database" hint. >>> >>> This is one of my first real commits to Netbeans, so there may be some >>> follow-up, cleanups, clarifications, so review input is greatly appreciated. >>> >>> Eric Bresie >>> [email protected] >>> >> -- > Eric Bresie > [email protected] >
