Getting close on NETBEANS-189 [1]... I’ve made changes to allow auto completion even without connection. It no longer shows the error except when attempting to execute a sql statement. Without connection it does not allow auto completion of identifiers based on connections.
Initially I added some hints/annotation, but these have been removed for now. So I’ve removed unnecessary changes from the PR so now down to 3 files have changed. Last concern is about usage of quoter in connection vs no connection contexts. I have a lengthy comment in the PR thread [2] for comments Connection are mainly done higher level in the auto completion activities which does some establishment of a quoter used later in the flow. With that in mind, in lower level the “quoter” is used to account for connected/non-connected state. When connection is available and attempting to provide identifier details it may be necessary to “unquote” depending on the DB in use on the connection. When no connection is known there is no real way to determine connection based details (i.e. can’t tell tables, columns, etc.) or how to handle “unquoting/quoting” fully. Suggested way forward is to break out / refactor some of this to allow “connected” or “unconnected” similar logic. So I’m trying to address this as the moment. So should an alternative “NoConnectionQuoter” be implemented based on SQLIdentifier.Quoter abstract or is something else needed here? — There is potential follow up work to include (1) adding hints [3] (2) keying on “SQL auto completion” settings (see [4] (3) re-assess agains other related SQL tickets which may be impacted References: [1] https://issues.apache.org/jira/browse/NETBEANS-189 [2] https://github.com/apache/netbeans/pull/2820#discussion_r615002468 [3] https://issues.apache.org/jira/browse/NETBEANS-5474 [4] https://issues.apache.org/jira/browse/NETBEANS-188 On Mon, Apr 5, 2021 at 1:56 PM Eric Bresie <[email protected]> wrote: > It pass this time. Thanks Neil. > > Can folks on the PR review, confirm the updates align with > expected/requested changes and see if I've missed anything? > > I'm new to the PR process in Github...do I need to close out comments in > the review or wait for the original reviewer to close out the given comment > concern? > > Eric > > Eric Bresie > [email protected] > > > On Mon, Apr 5, 2021 at 1:13 PM Neil C Smith <[email protected]> wrote: > >> On Mon, 5 Apr 2021, 19:05 Eric Bresie, <[email protected]> wrote: >> >> > However now I have a "Travis CI" issue showing like the below (see >> > https://travis-ci.com/github/apache/netbeans/jobs/496100592 ). Not sure >> > what is causing this now. >> > >> >> Have retriggered. See if it fails a second time. It's amongst a group of >> tests that tend (or tended) to fail randomly. >> >> Best wishes, >> >> Neil >> >> > >> > -- Eric Bresie [email protected]
