On Wed, 16 Feb 2022 at 23:51, Christian Oyarzun <[email protected]> wrote: > Junichi has built a robust PHP unit test suite and Tomáš made sure the > tests pass on both Windows and Linux. Since the tests are extensive, > the PHP editor tests take ~1.5hrs. This has been brought up in previous > threads. The PHP tests are run in the PHP and Windows workflows. > > I propose following to reduce wasting GitHub Actions resource: > > 1. Use the "on: [push,pull-request]: paths:" to only run the PHP > workflow when the php cluster or its dependencies have changed in one of > the commits. ... > Are these suggestions worth pursuing?
Absolutely! I started looking at updating to build on JDK 11 last month, but didn't get very far and unfortunately have not had time with the release to pursue further yet. https://github.com/apache/netbeans/pull/3444 That's high on my to-do list too, as we can't actually have modules that require building on JDK 11 yet until all our testing (and the Ant tasks they rely on!) are migrated. We need to get all tests building on JDK 11, and running on JDK 11 and 17 (and 8 where still required). I asked the question in the conversation on that PR about triggering some of the PHP tests based on paths and/or cron. We should also consider whether some more resource intensive tests only run daily IMO. There's also an odd issue to address with one of the PHP tests on JDK 11. We do already have some workflows (profiler) that run by path - one of those we learned the other week is broken - nothing has touched that in a long time. That's unlikely to be an issue with PHP, but something to consider if we only trigger on rarely changed paths. I'd also like to see if we can move some of the test running into scripts or similar (at least files listing the tests), so that we could more easily migrate between Travis and GitHub. Something we might want to do soon? Best wishes, Neil --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
