> > We do already have some workflows (profiler) that run by path - one of > those we learned the other week is broken - nothing has touched that > in a long time. That's unlikely to be an issue with PHP, but > something to consider if we only trigger on rarely changed paths.
I saw this as well and looked into it a bit this past weekend. There was a commit that fixed some typos in the java code that triggered the workflow. The workflow paths might need a little work, since I think the paths could be paired down a bit to only the required files. i.e. the java source required for jni headers, c source, and required build files. The build is failing on Windows because ~4 months ago GitHub updated the windows-latest image to include the Windows 11 SDK. https://github.com/actions/virtual-environments/commit/5690fb5b41628468394a0c009686f8de653c3ccc#diff-816219d3c9f30fcc1c40f88ca826c1662bf99eded781c1b419dd2dfb577ae227R425 https://bugs.python.org/issue45220 Potential fixes or workarounds: 1. Change .rc file similar to what they did in python? 2. Change workflow to specify SDK version using vcvarall.bat https://docs.microsoft.com/en-us/cpp/build/building-on-the-command-line?view=msvc-170#vcvarsall-syntax 3. Change workflow to use Windows 2016 image --Christian On Thu, Feb 17, 2022 at 4:39 AM Neil C Smith <[email protected]> wrote: > On Wed, 16 Feb 2022 at 23:51, Christian Oyarzun <[email protected]> wrote: > > Junichi has built a robust PHP unit test suite and Tomáš made sure the > > tests pass on both Windows and Linux. Since the tests are extensive, > > the PHP editor tests take ~1.5hrs. This has been brought up in previous > > threads. The PHP tests are run in the PHP and Windows workflows. > > > > I propose following to reduce wasting GitHub Actions resource: > > > > 1. Use the "on: [push,pull-request]: paths:" to only run the PHP > > workflow when the php cluster or its dependencies have changed in one > of > > the commits. > ... > > Are these suggestions worth pursuing? > > Absolutely! I started looking at updating to build on JDK 11 last > month, but didn't get very far and unfortunately have not had time > with the release to pursue further yet. > https://github.com/apache/netbeans/pull/3444 That's high on my to-do > list too, as we can't actually have modules that require building on > JDK 11 yet until all our testing (and the Ant tasks they rely on!) are > migrated. We need to get all tests building on JDK 11, and running on > JDK 11 and 17 (and 8 where still required). > > I asked the question in the conversation on that PR about triggering > some of the PHP tests based on paths and/or cron. We should also > consider whether some more resource intensive tests only run daily > IMO. There's also an odd issue to address with one of the PHP tests > on JDK 11. > > We do already have some workflows (profiler) that run by path - one of > those we learned the other week is broken - nothing has touched that > in a long time. That's unlikely to be an issue with PHP, but > something to consider if we only trigger on rarely changed paths. > > I'd also like to see if we can move some of the test running into > scripts or similar (at least files listing the tests), so that we > could more easily migrate between Travis and GitHub. Something we > might want to do soon? > > Best wishes, > > Neil > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > For further information about the NetBeans mailing lists, visit: > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > >
