On 27.03.22 03:37, Łukasz Bownik wrote:
Ok. 2 more questions If i fix something may I bump language version to 11?
unfortunately no. Many modules have still the requirement to run on 8. A lot of the language support features are used by the VSCode NB plugin, the platform still supports 8 too. Bumping versions would require more discussion here first.
I tend to use "final" keyword and static imports a lot. Is it ok?
final for fields/classes is great. I personally don't use final for temp vars since it creates often too much noise. Adding final to a private or static method is equivalent of not making it final, so its redundant there too IMO.
Static imports are ok as long it is still somewhat clear where the methods/fields are coming from. I would be a bit careful with overuse in some situations.
-mbien
On Sat, Mar 26, 2022, 3:15 PM Michael Bien <[email protected]> wrote: use whatever the file is using you are updating. For new files/new code use default netbeans formatting - there are no hard rules. Readability is important, if something can be improved/simpified it gonna be pointed out during PR review anyway. -mbien On 27.03.22 23:50, Łukasz Bownik wrote: > ok. I will install jdk 11 . by the way, what are coding conventions for > netbeans? > The url > https://netbeans.apache.org//community/guidelines/code-conventions.html > > Says page not found :( > > sob., 26 mar 2022, 12:55 użytkownik antonio <[email protected]> napisał: > >> Hi, >> >> NetBeans is built with JDK11 [1], but we're also compiling with other >> versions [2]. >> >> Cheers, >> Antonio >> >> [1] >> https://github.com/apache/netbeans/#readme >> >> [2] >> https://github.com/apache/netbeans/pull/3785 >> >> El 26/3/22 a las 16:21, Łukasz Bownik escribió: >>> Thanks. By the way. Which version of jdk shall I use? I run jdk17.0.2 and >>> unit tests keep crashing with a strange exception. >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> >> For further information about the NetBeans mailing lists, visit: >> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists >> >> >> >>
