mbien commented on code in PR #3558:
URL: https://github.com/apache/netbeans/pull/3558#discussion_r841293743
##########
apisupport/maven.apisupport/src/org/netbeans/modules/maven/apisupport/NBMNativeMWI.java:
##########
@@ -247,7 +247,7 @@ public void performOperation(POMModel model) {
//nbm-maven-plugin
boolean addPlugin = true;
String managedPVersion = null;
- String pVersion =
MavenNbModuleImpl.getLatestNbmPluginVersion();
+ String pVersion = MavenNbModuleImpl.LATEST_NBM_PLUGIN_VERSION;
Review Comment:
it is intended, Its this commit:
https://github.com/apache/netbeans/pull/3558/commits/5b9efc25e765714a31e094e05be661afc88ff4b0
explanation is here:
https://github.com/apache/netbeans/pull/3558#issuecomment-1045585199
short version:
code swallowed a NPE which basically made the tests test nothing, post
upgrade the NPE did not occur and the tests tried to download the maven repo
index which caused them to time out
by returning a constant (again, i basically reverted a older commit) and not
ignoring the exception, everything works again.
Yes, semantics changed a little to the old behavior before
57e21b83150cc4d7e380c53c2b990c6c6e69bc52
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
