mbien commented on code in PR #3558:
URL: https://github.com/apache/netbeans/pull/3558#discussion_r841295009


##########
java/maven.indexer/src/org/netbeans/modules/maven/indexer/ClassDependencyIndexCreator.java:
##########
@@ -168,50 +166,49 @@ private static boolean isArchiveFile(File jar) throws 
IOException {
     }
 
     static void search(String className, Indexer indexer, 
Collection<IndexingContext> contexts, List<? super ClassUsage> results) throws 
IOException {
-        String searchString = crc32base64(className.replace('.', '/'));
-        Query refClassQuery = 
indexer.constructQuery(ClassDependencyIndexCreator.FLD_NB_DEPENDENCY_CLASS.getOntology(),
 new StringSearchExpression(searchString));
-        TopScoreDocCollector collector = 
TopScoreDocCollector.create(NexusRepositoryIndexerImpl.MAX_RESULT_COUNT, null);
+        String searchString = crc32base32(className.replace('.', '/'));

Review Comment:
   good question. I haven't tested that situation at all tbh since a NB upgrade 
does not copy cache files. Lucene 5 index would be incompatible with 8 anyway - 
Its likely the exiting code would reset the index on failure. 
   
   I am going to copy the index from NB 13 to a test setup and see how it 
behaves.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



Reply via email to