> My question is: shouldn't this be changed upstream? The window system tabs are not actually part of the upstream FlatLAF library--they are in the FlatLAF customization module inside the NetBeans codebase. So it's easy to change.
-- Eirik -----Original Message----- From: Michael Bien <mbie...@gmail.com> Sent: Friday, June 24, 2022 2:59 PM To: dev@netbeans.apache.org; Neil C Smith <neilcsm...@apache.org> Subject: Re: FlatLAF tab style discussion On 24.06.22 17:11, Neil C Smith wrote: > On Fri, 24 Jun 2022 at 10:46, Eirik Bakke <eba...@ultorg.com> wrote: >> With FlatLAF becoming the default look & feel since NetBeans 13, the tab >> components in the window system (over editors and sidebars) no longe >> resemble tabs, and are somewhat difficult to see. The proposed PR fixes >> this, by introducing a new look for the tabs that shows the selected tab as >> a proper tab while leaving a simplified flattened look for unselected tabs. > To be clear, considering my -0, I totally agree with the visibility > point. This needs fixing, and I think the tabbed pane UI in FlatLaf > has an accessibility issue here anyway. I just don't think that > changing the design of the tabs (particularly making them not flat) is > the way to fix it. I think the colour palette needs more contrast / > accenting. You can see this in some of the other software screenshots > you shared there. You can also see it in menus, option categories, > etc. I believe the problem with the tabs is more than the gradients/colors. The active tab looks like it is not attached to the editor due to the separator line. It doesn't look as if it would be on the same "3d level", which lets me intuitively second guess if the active tab is actually the active tab. (I am not saying the colors should not be changed too) But since even intelliJ moved that line up, everything indicates that more share the same opinion / have a problem with it. My question is: shouldn't this be changed upstream? Because this sounds like an issue which might be potentially changed upstream. To avoid having to revert this we should check If there is no desire to provide the option or change it upstream, if there isn't - we should merge IMO (I really like it as i already said on the PR). regarding on or off: good defaults are important. So we should try to set it to the most popular option so that only few have to change the default (I hope enabled is the most popular option ;)). best regards, michael > > I would also say I do think the PR should probably be merged. I was > hoping Karl might have some thoughts on fixing some of the issues in a > way that more aligns with other areas of FlatLaf, but we can always > tweak further afterwards ... > > Best wishes, > > Neil > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org > For additional commands, e-mail: dev-h...@netbeans.apache.org > > For further information about the NetBeans mailing lists, visit: > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
