On 17. 02. 23 11:17, Neil C Smith wrote:
Definitely in favour of the command line parameter. But, does it
absolutely need launcher changes to achieve it? Not achievable by
parsing the command line argument in MainImpl like you're doing with
the system property?
The thing is that the --clusters (+netbeans_extra_clusters config
option) is processed into "netbeans.dirs" system property by
launcher(s). That property is read from many places, sadly and is
public/documented (arch.xml) alghouth as "friend" category.
The implementation could possibly read "--add-clusters" at the very
start of the bootstrap, using custom code as we need (IMHO) to patch the
combined value back as soon as possible so that even CLIHandlers observe
the correct value. No existing code is really prepared for this value to
be mutable.
That's partially why I/Dusan considered the quickfix just temporary: it
patches the system property back.
A mirroring subtractive cluster parameter might be useful?
I could imagine it could be - but would be also more tough i.e. we can
run into path normalization + comparison, in win / shellscript.
Q4: are there other pending issues that could be addressed in the new
launcher release ? I've searched GH issues and didn't found much.
[...]
Would you file those as issues ?
-S.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
