we have to make up our mind how to handle testing :)
if we simply merge it to master as detached cluster, it sidelines CI
completely as previously mentioned and we could essentially turn CI off
if a PR is labeled with 'rust'.
We can fix this of course, but we have to figure out how.
a) the "rust" branch approach
we switch everything in main.yml to the rust cluster in that branch and
make sure the commit won't get merged once we merge rust with master.
b) we merge to master right away, but we will have to add rust to a
cluster config which is essentially release+rust and use this config for CI
c) something else...
best regards,
michael
On 26.02.23 12:58, Antonio wrote:
Hi,
So I skipped 1.2 and did a PR against master.
Let me know if you prefer a PR against a "rust" branch, though.
Kind regards,
Antonio
[1]
https://github.com/apache/netbeans/pull/5567
On 24/2/23 18:21, Michael Bien wrote:
On 24.02.23 18:21, Neil C Smith wrote:
On Fri, 24 Feb 2023 at 17:12, Michael Bien <mbie...@gmail.com> wrote:
We could skip 1.2 if you want and go right to master and develop it
there, no?
...
Regarding testing... As you probably know, github actions build the
'release' cluster config in a matrix, ...
I was with you initially on skipping 1.2. However, the other approach
to this might be a Rust branch and an active (unmerged) PR from there
to master. Like we do with sync PRs. That runs the tests when
anything is merged into the branch. The Rust modules / cluster can
then be included in the release cluster config within that branch for
testing purposes? Until we decide it's ready to merge to master, and
we have to decide whether to include in the release.
good idea!
(Although I wouldn't recommend to do that "forever". The more eyes we
have which look at the code the better, and 99% of the devs going to
have master checked out/built/tested etc.)
-mbien
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
