On 10/10/26 22:09, Matthias Bl�sing via dev wrote: > Hi, > > Am Donnerstag, dem 01.10.2026 um 08:55 +0200 schrieb Jaroslav Tulach: > >> [NetBeans fails to build on JDK25+ without messing with ANT_OPTS] >> [Suggestion: set required system property from custom ANT task] > I think the idea is worth implementing. There was an issue raised for > this and I think saying "yeah we know, just mess with environment" is > not a nice answer and the build system making the necessary adjustments > ist sane from my POV.
I remember that we had to add that while having to fix a chain of jenkins build failures during release - and one issue required that we bump the JDK version for the javadoc job (which also required asf infra involvement since it wasn't on the right update level etc) last minute which lead us to this quick fix. I have nothing against trying to make it easier to build NB for users, but setting magic values has also its downsides. After a while we will forget that it is hardcoded and might find another way to set it - likely "from the outside" again. Right now its in the README, and in the build config https://github.com/apache/netbeans/blob/d5a2acdc71f22a0bf57f6e4cbe4f03673949c83e/.github/workflows/main.yml#L471-L472 which makes it really easy to find and maintain. Here is another report about magic hardcoded flags which are set without appearing in any config files: https://github.com/apache/netbeans/issues/9614 > I don't see an attack vector there as we control we input and even if > not it is not an unbounded sie. agreed. This particular limit is a parser cumulative total and makes DOS easier to detect - there are other limits which are per entity etc. We could probably set it to 0 without worrying too much about it but the increased limit we use now seems to work pretty well since the time we bumped it. best regards, mbien --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
