On Sat, 10 Oct 2026 at 23:08, Michael Bien <[email protected]> wrote: > On 10/10/26 22:09, Matthias Bl�sing via dev wrote: > > I think the idea is worth implementing. There was an issue raised for > > this and I think saying "yeah we know, just mess with environment" is > > not a nice answer and the build system making the necessary adjustments > > ist sane from my POV. ... > I have nothing against trying to make it easier to build NB for users, > but setting magic values has also its downsides. > > After a while we will forget that it is hardcoded and might find another > way to set it - likely "from the outside" again.
Yes, my initial response was not meant to be discouragement against adding sensible defaults in the build, just pointing out that this is not an unknown issue. >From what I recall, part of the reason for setting it "from the outside" was that doing so didn't require changes in already released branches. Having things set externally can sometimes be useful for us, particularly in chicken and egg situations. Version info is also managed externally, and I think we've had more questions about how to make a source zip from the tag build correctly than about Javadoc builds. There are other quirks to the environment required for Javadoc builds too, such as different JDK requirements. And I think at one point to get a correct build, we had to use a JDK that matched the (nbjavac) compiler version? Still, Eric is probably the best person to review any changes here. I added him to the PR reviewers. Best wishes, Neil --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
