Github user jlahoda commented on a diff in the pull request:

    https://github.com/apache/incubator-netbeans/pull/6#discussion_r140850999
  
    --- Diff: 
db/test/unit/src/org/netbeans/modules/db/explorer/DbDriverManagerTest.java ---
    @@ -221,7 +221,7 @@ private static JDBCDriver createJDBCDriver() {
         
         private static JDBCDriver createDummyJDBCDriver(File dataDir) throws 
MalformedURLException {
             URL url = dataDir.toURL();
    -        return JDBCDriver.create("test_driver", "DbDriverManagerTest 
DummyDriver", "DummyDriver", new URL[] { url });
    +        return JDBCDriver.create("test_driver", "DbDriverManagerTest 
DummyDriver", 
"org.netbeans.modules.db.explorer.DbDriverManagerTest$DriverImpl", new URL[] { 
url });
    --- End diff --
    
    So what is the significance of this change? (If it is unrelated to 
"license" review, then I'd suggest to send it separately, for clarity.)


---

Reply via email to