Github user jlahoda commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/6#discussion_r141172728
--- Diff:
db/test/unit/src/org/netbeans/modules/db/explorer/DbDriverManagerTest.java ---
@@ -221,7 +221,7 @@ private static JDBCDriver createJDBCDriver() {
private static JDBCDriver createDummyJDBCDriver(File dataDir) throws
MalformedURLException {
URL url = dataDir.toURL();
- return JDBCDriver.create("test_driver", "DbDriverManagerTest
DummyDriver", "DummyDriver", new URL[] { url });
+ return JDBCDriver.create("test_driver", "DbDriverManagerTest
DummyDriver",
"org.netbeans.modules.db.explorer.DbDriverManagerTest$DriverImpl", new URL[] {
url });
--- End diff --
If I were doing this, I'd probably do two commits - one license-related
cleanup, and one test fix/cleanup. OTOH, I don't think this is important enough
to block the change on it, so I'll leave the decision on you on this matter.
---
