OK, think I got it now. https://github.com/apache/incubator-netbeans/pull/75
https://github.com/apache/incubator-netbeans/pull/76 I now have a fork with a branch for the two modules I am reviewing, enabling me to do a PR per module that I have reviewed. Hope this is the right way to go. Any feedback or comments welcome, since there'll be a lot more of these from me. Gj On Sat, Oct 7, 2017 at 12:14 PM, Geertjan Wielenga < [email protected]> wrote: > Do the names of those branches make sense? > > My plan is to push from my local git clone of my fork into those two > branches for the license header changes for the api.visual and > api.templates modules. > > Does that make sense? > > If so, will make a short screencast of this for others, if this is the > optimum way of doing the process. > > Thanks, > > Gj > > On Sat, Oct 7, 2017 at 12:02 PM, Geertjan Wielenga < > [email protected]> wrote: > >> Thanks. >> >> Gj >> >> On Sat, Oct 7, 2017 at 11:45 AM, Cezariusz Marek < >> [email protected]> wrote: >> >>> Use "git branch -r" (or -rv) to see remote branches. >>> >>> -- >>> Cezariusz Marek >>> >>> >>> -----Original Message----- >>> From: Geertjan Wielenga [mailto:[email protected]] >>> Sent: Saturday, October 7, 2017 11:22 AM >>> To: [email protected] >>> Subject: Re: Two module reviews in one PR >>> >>> I've created two branches via the UI on GitHub: >>> >>> https://github.com/geertjanw/incubator-netbeans/branches >>> >>> How do I see them when I do 'git branch -v' or am I doing something >>> wrong? >>> >>> Gj >>> >>> On Fri, Oct 6, 2017 at 11:07 PM, Matthias Bläsing < >>> [email protected] >>> > wrote: >>> >>> > Hey Geertjan, >>> > >>> > Am Freitag, den 06.10.2017, 22:54 +0200 schrieb Geertjan Wielenga: >>> > > OK, many thanks, it all seems to work, took all the steps and almost >>> > > completely understood them, but at the final step permission was >>> > > denied. So, I need to set up SSH keys for this stage? >>> > >>> > Could you give the Input+Output of the commands? For github for >>> > example I use an ssh key - and that needs to be accessible when I push >>> > to github. This is in contrast to apache, which only offer >>> > username+password access. >>> > >>> > The output of "git remote -v" in combination with the exact command >>> > you ran might be helpful. >>> > >>> > > The other thing is that I am able to push directly to Apache Git >>> > > (did several pushes, e.g., I pushed the README there, and updated >>> > > it, for >>> > > example) and now though, from my branch, I am unable to do that -- >>> > > just wondering why that might be. >>> > >>> > git has different was to determine where to push. You can specify the >>> > target in the push or if you are not doing that the push reaches the >>> > upstream branch. Here from my repo: >>> > >>> > matthias@athena:~/src/incubator-netbeans$ git branch -vv >>> > db.core-review fa9676d56 [origin/db.core-review] [NETBEANS-54] >>> > Module Review db.core >>> > derby-review 3d3a135ec [origin/derby-review] [NETBEANS-54] Module >>> > Review derby >>> > master 728d70cad [upstream/master: 1 hinterher] [NETBEANS-54] >>> > Module Review spi.palette >>> > xml1-review c9a38cb65 [origin/xml1-review] [NETBEANS-54] Module >>> > review xml.text >>> > * xml2-review 040248f91 [NETBEANS-54] Modules review xml.xdm >>> > matthias@athena:~/src/incubator-netbeans$ >>> > >>> > In this case there are 4 branches with upstreams configured (the first >>> > 4 entries). If I'm in one of these branches, a "git push" pushes to >>> > the configured target. >>> > >>> > Maybe that already clears it up? One final advise: >>> > >>> > Check with "git branch" in which branch you are and if it is the same, >>> > that you'd expect. >>> > >>> > Greetings >>> > >>> > Matthias >>> > >>> >>> >> >
