I get a different build error:
BUILD FAILED
/home/ate/tmp/netbeans/netbeans-platform-source-platform-9.0-alpha/nbbuild/build.xml:122:
Download of
276009D3F0A27079A80D241C3183EC712305A42A-net.java.html.boot.script-1.5.jar
produced content with hash 5DE9DD70EDCD9B30E0671ACC813F6F0C80E951AA when
276009D3F0A27079A80D241C3183EC712305A42A was expected
But disregarding the above, I think a more serious, blocking, issue is
that AFAICT *not* all platform modules have been reviewed yet.
I notice this release candidate includes the apisupport.harness module.
And that still has status "To do". Furthermore, it depends on the *GPL*
external jsearch-2.0_05.jar which is a no-go... for the ASF.
See: https://www.apache.org/legal/resolved.html#category-x
I haven't looked in more detail yet, but before spending more time on it
I'd like to know if the inclusion of the harness module is an oversight
which can be quickly fixed. Regardless, I think this should be fixed first.
Note that the binary also includes the jsearch jar.
And while the binary isn't the release itself, if/when a convenience
binary is provided *then* it needs to be in compliance with the
distribution rules. So no GPL artifacts allowed.
I also see the bundled LICENSE and NOTICE files in the binary zip
are a bit weirdly formatted and the NOTICE file in particular.
Seems both are produced by concatenating several files together, but
the result is confusing, especially the NOTICE file.
The NOTICE file should only contain what is needed, nothing
more. Of the current content only the OSGi Alliance notice seems to be
needed, beside the base NOTICE header.
The LICENSE file correctly lists and appends the 3rd party licenses,
but:
a) The jsearch GPL-2-CP license obviously shouldn't be there (see above)
b) The jemmy *external* libraries are available under CDDL or GPL-2-CP,
in which case we simply 'pick' CDDL and don't need to include/append
the GPL-2CP license too.
This is (AFAIK) not blocking, but preferred to remove the GPL-2-CP
license text as it easily can 'trip' casual reviewers or even
automatic license scanning tools which may draw the wrong conclusion.
(and why is jemmy an external dependency and not part of the code
donation?)
Finally, I tried to start the binary.
Sorry for probably being a noob here but I can't figure out if I'm doing
something wrong or the binary itself has a problem.
If I try to just run the bin/netbeans shell script, I get the following
error:
WARNING [org.netbeans.core.startup.Main]
java.lang.NoClassDefFoundError: org.netbeans.license.AcceptLicense
starting from org.netbeans.MainImpl$BootClassLoader@1c20c684 with
possible defining loaders null and declared parents ]
at org.netbeans.core.startup.Main.getKlass(Main.java:341)
Ate
On 2017-11-07 21:49, John McDonnell wrote:
I want to vote yes, but should the sources be buildable?
If I execute ant the build fails?
$ ant
...
[insert-module-all-targets] This module is missing from checkout:
maven.apisupport - at least can't find:
/Users/john/Downloads/netbeans-platform-source-platform-9.0-alpha/maven.apisupport/build.xml
[insert-module-all-targets] This module is missing from checkout:
timers - at least can't find:
/Users/john/Downloads/netbeans-platform-source-platform-9.0-alpha/timers/build.xml
BUILD FAILED
/Users/john/Downloads/netbeans-platform-source-platform-9.0-alpha/nbbuild/build.xml:156:
Some modules according your cluster config 'basic' are missing from
checkout, see messages above.
I removed all but 2 of the errors.
Am I missing something? If I am then I'll happily vote +1 (non binding)
Regards
John
On 7 November 2017 at 19:20, Benny Neugebauer <[email protected]> wrote:
+1
But the link to the artifact is broken. It should be:
https://builds.apache.org/view/Incubator%20Projects/job/incubator-netbeans-release/lastSuccessfulBuild/artifact/dist/netbeans-platform-source-platform-9.0-alpha.zip
On 2017-11-07 11:17, Geertjan Wielenga <[email protected]> wrote:
Hi all,>
Please vote on releasing Apache NetBeans 9.0 Alpha (incubating)! If this>
voting passes, another similar voting will be started on>
[email protected], and if that passes too, then we can release>
this version.>
Apache NetBeans 9.0 Alpha (incubating) are the modules of Apache NetBeans>
that provide the application framework of NetBeans, that is, the NetBeans>
Platform.>
Build artifacts:>
https://builds.apache.org/view/Incubator%20Projects/job/incubator-netbeans-release/>
Source md5sum is 548058644764a07ef54568aa79a10aa1.>
The artifact to be voted on:>
https://builds.apache.org/view/Incubator%20Projects/job/incubator-netbeans-release/lastSuccessfulBuild/artifact/dist/netbeans-platform-source-.zip>
Rat report shows no unknown licenses:>
https://builds.apache.org/view/Incubator%20Projects/job/incubator-netbeans-release/lastSuccessfulBuild/artifact/rat-temp/nbbuild/build/rat-report.txt>
Included as a convenience is a binary, unzip it and run it and you'll see>
the NetBeans Platform:>
https://builds.apache.org/view/Incubator%20Projects/job/incubator-netbeans-release/lastSuccessfulBuild/artifact/dist/netbeans-platform-bin-.zip>
Included in the above are the DEPENDENCIES%2
