It seems that even when I start up on JDK 9, I get a notification message that I should install nb-javac for "improved Java editing experience".
I think if JDK 9 is used, since javac from the JDK is then used, we should leave it at that and not tell the user to install nb-javac. Gj On Sun, Dec 17, 2017 at 12:10 PM, Geertjan Wielenga < geertjan.wiele...@googlemail.com> wrote: > https://cwiki.apache.org/confluence/display/NETBEANS/Overview%3A+nb-javac > > Gj > > On Sun, Dec 17, 2017 at 12:09 PM, Peter Steele <steeleh...@gmail.com> > wrote: > >> Is there anything anywhere saying why netbeans needs its own java compiler >> (nb-javac) What features require this? I'm just surprised that netbeans >> was >> ever built with a custom javac. >> >> On 17 Dec 2017 11:03, "Geertjan Wielenga" <geertjan.wielenga@googlemail. >> com> >> wrote: >> >> It's great and works for me and complies with the instructions we have >> received re nb-javac, i.e., users must explicitly choose to install it and >> agree to its licensing terms. >> >> I have updated the Beta planning page to show the solution via the most >> important dialog boxes: >> >> https://cwiki.apache.org/confluence/display/NETBEANS/ >> Apache+NetBeans+9.0+Beta >> >> But why the "highly recommended" in bold for nb-javac? I'd omit this, I >> think it's up to the user and could be confusing. >> >> Gj >> >> >> On Sun, Dec 17, 2017 at 9:20 AM, Jan Lahoda <lah...@gmail.com> wrote: >> >> > Hi, >> > >> > I've updated the jdk-javac branch (in the incubator-netbeans repository) >> to >> > run on JDK 8 even without nb-javac, and show a dialog (on the first run) >> or >> > a notification to install nb-javac (or run on JDK 9). My plan is to >> make a >> > pass through the patch and send a pull request. But it would be helpful >> if >> > someone would be willing to try the branch and provide feedback if >> needed. >> > >> > Thanks, >> > Jan >> > >> > >> > On Tue, Dec 12, 2017 at 7:20 PM, Jan Lahoda <lah...@gmail.com> wrote: >> > >> > > Hello, >> > > >> > > Today, we were talking with Jarda (jtulach) and Geertjan about what do >> we >> > > do with the Java support for the beta release. >> > > >> > > I think the proposal is roughly like this: >> > > -the jdk-javac branch will be updated to >> > > --allow the IDE to start on JDK 8, with javac based Java features >> > disabled >> > > (as best as we can, some exceptions might still happen, which we will >> > > resolve as we find them). >> > > --when running on JDK 8, there will be a notification/popup/dialog >> that >> > > the Java features are disabled and that the IDE either needs to run on >> > JDK >> > > 9 or later, or the additional nb-javac module must be installed (the >> > latter >> > > being preferred, a "link" to perform the action included) >> > > --when running on JDK 9, show (once?) a notification/popup that the >> IDE's >> > > behavior may improve by installing the additional nb-javac module. >> > > -critical problems with the jdk-javac branch that we find should be >> fixed >> > > -a pull request to merge the jdk-javac branch into master will be sent >> > > >> > > (Jarda, please correct me if I missed something.) >> > > >> > > Are there any comments/objections/help offers to this proposal? >> > > >> > > I'd like to get to this later this week. >> > > >> > > Thanks, >> > > Jan >> > > >> > > >> > >> > >
