Hi Jaroslav, I'm just catching up from a holiday weekend and will give this a look tomorrow or the next day.
Thanks for reaching out! Talk soon. Cheers, Eric On Mon, May 28, 2018 at 7:53 AM Jaroslav Tulach <jaroslav.tul...@gmail.com> wrote: > Thanks a lot Hans, for connecting me with potential reviewers. > > Hello Piotr, Eric, [my PR]( > https://github.com/apache/incubator-netbeans-html4j/pull/6) has already > been merged, but I'll be thankful for any comments. I can fix them in > another PR. Especially the way I [hook between compile and jar targets]( > https://github.com/apache/incubator-netbeans-html4j/pull/6/files#diff-1c983dc3ce8878c646f01e6fe5001845R42) > feels slightly hacky. I just don't know a better solution. > > Thanks for any advice. > -jt > > > 2018-05-25 20:44 GMT+02:00 Hans Dockter <h...@gradle.com>: > >> Hi Jaroslav, >> >> Sorry for the late response. I'm adding Piotr and Eric from the Gradle >> build tool team to have a look at this and see what we can do to help. >> >> Hans >> >> On Thu, Apr 19, 2018 at 11:58 AM Jaroslav Tulach < >> jaroslav.tul...@gmail.com> wrote: >> >>> Hello guys, hello Laszlo. >>> >>> For a while I was considering to expand the reach of the HTML/Java class >>> post processing. So far we could do that from a command line and via a >>> Maven plugin. There is a pull request >>> https://github.com/apache/incubator-netbeans-html4j/pull/6 that tries >>> to do the same for Gradle. It works to some extent, but a review is needed. >>> It is my first real Gradle plugin... Especially the way it inserts itself >>> between compilation and packaging feels wild... >>> >>> Thanks in advance for your advices at >>> https://github.com/apache/incubator-netbeans-html4j/pull/6 >>> -jt >>> >>> PS: The challenge was to build the plugin with Maven. It is not easy to >>> find proper Gradle JARs in Maven repositories. As such I decided to resort >>> to a bit of reflection in some situations. >>> >> -- >> >> [image: email-signat...@2x.png] >> >> Hans Dockter >> >> CEO & Founder >> >> Gradle Inc. >> >> W. gradle.com >> > > -- [image: email-signat...@2x.png] Eric Wendelin Developer Experience Gradle Inc. P. +1 303 579 0246 W. gradle.com
