Hi,

I'm trying to do the module review of the web.beans one, just forked and
created the branch I'm working on.
I'm following this PR[1], done by Junichi and trying to write some steps to
follow:

1 - add licenseinfo.xml - what to put here, just images files? I'm using
this search [2]

[code]
$ find . -type f -exec file {} \; | awk -F: '{if ($2 ~/image/) print $1}'
./src/org/netbeans/modules/web/beans/resources/delegate.png
./src/org/netbeans/modules/web/beans/resources/injection_point.png
./src/org/netbeans/modules/web/beans/resources/event.png
./src/org/netbeans/modules/web/beans/resources/observer.png
[/code]

2 - change the license header of Bundle.properties - just the
resources/Bundle one, what about the others?

[code]
 $ find -iname bundle.properties
./src/org/netbeans/modules/web/beans/impl/model/Bundle.properties
./src/org/netbeans/modules/web/beans/analysis/analyzer/annotation/Bundle.properties
./src/org/netbeans/modules/web/beans/analysis/analyzer/type/Bundle.properties
./src/org/netbeans/modules/web/beans/analysis/analyzer/Bundle.properties
./src/org/netbeans/modules/web/beans/analysis/analyzer/field/Bundle.properties
./src/org/netbeans/modules/web/beans/analysis/analyzer/method/Bundle.properties
./src/org/netbeans/modules/web/beans/analysis/Bundle.properties
./src/org/netbeans/modules/web/beans/resources/Bundle.properties
./src/org/netbeans/modules/web/beans/actions/Bundle.properties
./src/org/netbeans/modules/web/beans/Bundle.properties
./src/org/netbeans/modules/web/beans/navigation/actions/Bundle.properties
./src/org/netbeans/modules/web/beans/navigation/Bundle.properties
./src/org/netbeans/modules/web/beans/wizard/Bundle.properties
./src/org/netbeans/modules/web/beans/hints/Bundle.properties
[/code]

So, anything more?

[1] https://github.com/apache/incubator-netbeans/pull/662

[2] https://stackoverflow.com/a/24879385/269514

Reply via email to