Hi, I assume have read the information in [1] List of Modules to Review <https://cwiki.apache.org/confluence/display/NETBEANS/List+of+Modules+to+Review> page as mentioned on the top of [2] 2nd Donation: List of Modules to Review <https://cwiki.apache.org/confluence/display/NETBEANS/2nd+Donation%3A+List+of+Modules+to+Review>
As you have selected the web.beans module, Did you try ctrl+f (find) for *web.beans* in [3] Rat report <https://builds.apache.org/job/incubator-netbeans-linux/lastSuccessfulBuild/artifact/nbbuild/build/rat-report.txt> to see the Files listed with unapproved licenses under the selected module? If you see any files that need to be licensed, you may license the files, follow the procedure in [1] List of Modules to Review <https://cwiki.apache.org/confluence/display/NETBEANS/List+of+Modules+to+Review>, skim through the module to confirm everything is fine and then submit a PR. [1] https://cwiki.apache.org/confluence/display/NETBEANS/List+of+Modules+to+Review [2] https://cwiki.apache.org/confluence/display/NETBEANS/2nd+Donation%3A+List+of+Modules+to+Review [3] https://builds.apache.org/job/incubator-netbeans-linux/lastSuccessfulBuild/artifact/nbbuild/build/rat-report.txt *Kind regards, * *Thilina Ranathunga.* On Mon, Aug 13, 2018 at 10:01 PM Gilberto <[email protected]> wrote: > Hi, > > I'm trying to do the module review of the web.beans one, just forked and > created the branch I'm working on. > I'm following this PR[1], done by Junichi and trying to write some steps to > follow: > > 1 - add licenseinfo.xml - what to put here, just images files? I'm using > this search [2] > > [code] > $ find . -type f -exec file {} \; | awk -F: '{if ($2 ~/image/) print $1}' > ./src/org/netbeans/modules/web/beans/resources/delegate.png > ./src/org/netbeans/modules/web/beans/resources/injection_point.png > ./src/org/netbeans/modules/web/beans/resources/event.png > ./src/org/netbeans/modules/web/beans/resources/observer.png > [/code] > > 2 - change the license header of Bundle.properties - just the > resources/Bundle one, what about the others? > > [code] > $ find -iname bundle.properties > ./src/org/netbeans/modules/web/beans/impl/model/Bundle.properties > > ./src/org/netbeans/modules/web/beans/analysis/analyzer/annotation/Bundle.properties > > ./src/org/netbeans/modules/web/beans/analysis/analyzer/type/Bundle.properties > ./src/org/netbeans/modules/web/beans/analysis/analyzer/Bundle.properties > > ./src/org/netbeans/modules/web/beans/analysis/analyzer/field/Bundle.properties > > ./src/org/netbeans/modules/web/beans/analysis/analyzer/method/Bundle.properties > ./src/org/netbeans/modules/web/beans/analysis/Bundle.properties > ./src/org/netbeans/modules/web/beans/resources/Bundle.properties > ./src/org/netbeans/modules/web/beans/actions/Bundle.properties > ./src/org/netbeans/modules/web/beans/Bundle.properties > ./src/org/netbeans/modules/web/beans/navigation/actions/Bundle.properties > ./src/org/netbeans/modules/web/beans/navigation/Bundle.properties > ./src/org/netbeans/modules/web/beans/wizard/Bundle.properties > ./src/org/netbeans/modules/web/beans/hints/Bundle.properties > [/code] > > So, anything more? > > [1] https://github.com/apache/incubator-netbeans/pull/662 > > [2] https://stackoverflow.com/a/24879385/269514 >
