On 19 Sep 2018, at 17:21, Geertjan Wielenga <[email protected]<mailto:[email protected]>> wrote:
Probably no one will help until you put a link here to your fork where the file you're talking about is found. Gj https://github.com/markee174/incubator-netbeans/blob/master/localhistory/src/org/netbeans/modules/localhistory/LocalHistoryProvider.java I add the actions at lines 120-121 but they are not called by the NetBeans callback. Does that makes sense? Kind Regards, MArk On Wed, Sep 19, 2018 at 6:14 PM, mark stephens < [email protected]<mailto:[email protected]>> wrote: On 19 Sep 2018, at 17:03, Geertjan Wielenga <[email protected]<mailto:[email protected]>> wrote: Point to your code in the fork where we can take a look at it. Gj I have hacked ShowHistoryAction to it can open a tab with multiple history values from multiple files (I do this in HistoryFileView). I do this in ShowHistoryAction class performAction(Node[] activatedNodes). For the moment, I am keeping all the Nodes so that i can access in other places where I need to override the code. I am trying to persuade NetBeans to work as usual with single entry as it expects and then merge in additional data when I need it so I can avoid having to rewrite the plumbing. In LocalHistoryProvider I have added an additional Action in LocalHistoryProvider so I have RevertFilesAction and the original RevertFileAction which I pass in with private synchronized Action[] getActions() in LocalHistoryProvider. But neither of these is called by the NetBeans Action system. Does that make sense? Kind Regards, MArk On Wed, Sep 19, 2018 at 5:27 PM, mark stephens < [email protected]<mailto:[email protected]>> wrote: I am still hitting a roadblock because I do not understand why my actions are not called when I select multiple files. Once I have this working I can implement multiple history in NetBeans IDE with rollback. Any suggestions or pointers to resources which might help me to understand why NetBeans is not calling actions in ShowHistoryAction? Kind Regards, MArk On 10 Sep 2018, at 19:11, mark stephens <[email protected]<mailto:[email protected]> <mailto:[email protected]>> wrote: Thanks for the pointers. I have raised as https://issues.apache.org/jira/browse/NETBEANS-1230 I have pushed my initial code which allows opening of a window with history from multiple files to my fork at https://github.com/markee174/ incubator-netbeans I am now seeking advice on the code so far (I know it can be done more elegantly) and how I get my actions to get called when the menu item is executed (ie RevertFileAction, RevertFilesAction). Kind Regards, MArk --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected]<mailto:[email protected]> For additional commands, e-mail: [email protected]<mailto:[email protected]> For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
