On 09/24/2018 09:12 AM, Glenn Holmer wrote: > I've submitted a PR to update the PostgreSQL driver: > https://github.com/apache/incubator-netbeans/pull/900 > > Since this is my first PR, would someone please review it to ensure that > I've submitted it properly?
I see the Travis build failed because "ide/db.drivers/external/postgresql-42.2.5-license.txt contains a license body which does not match that in nbbuild/licenses/BSD-postgresql". Looks like I missed something in VerifyLibsAndLicenses.java. What is the correct way to fix this? I copied the license straight from the Postgres JDBC driver site. Must the one in nbbuild be replaced as well? What is the reason for having another copy there, is it to do with Rat? When it's fixed, what's the proper way to correct the PR? Delete it and create a new one? -- Glenn Holmer (Linux registered user #16682) "After the vintage season came the aftermath -- and Cenbe." --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
