Excellent, thank you Gj. On Mon, Sep 24, 2018 at 1:50 PM Geertjan Wielenga <[email protected]> wrote:
> No, John McD. is right. > > Gj > > On Monday, September 24, 2018, Carl Mosca <[email protected]> wrote: > > > Good to know...I thought I read about a requirement for a single commit. > > > > On Mon, Sep 24, 2018 at 1:29 PM John McDonnell <[email protected] > > > > wrote: > > > > > HI Glenn, > > > > > > I can't talk about the license as I cant see it at the > moment(travelling) > > > but you can continue pushing changes to your local branch, and GitHub > > will > > > continue to include those changes into the PR. > > > > > > So no need to delete the existing PR. > > > > > > Regards > > > > > > John > > > > > > On Mon, 24 Sep 2018 at 16:18, Glenn Holmer <[email protected] > > > > > wrote: > > > > > > > On 09/24/2018 09:12 AM, Glenn Holmer wrote: > > > > > I've submitted a PR to update the PostgreSQL driver: > > > > > https://github.com/apache/incubator-netbeans/pull/900 > > > > > > > > > > Since this is my first PR, would someone please review it to ensure > > > that > > > > > I've submitted it properly? > > > > > > > > I see the Travis build failed because > > > > "ide/db.drivers/external/postgresql-42.2.5-license.txt contains a > > > > license body which does not match that in > > > > nbbuild/licenses/BSD-postgresql". Looks like I missed something in > > > > VerifyLibsAndLicenses.java. > > > > > > > > What is the correct way to fix this? I copied the license straight > from > > > > the Postgres JDBC driver site. Must the one in nbbuild be replaced as > > > > well? What is the reason for having another copy there, is it to do > > with > > > > Rat? > > > > > > > > When it's fixed, what's the proper way to correct the PR? Delete it > and > > > > create a new one? > > > > > > > > -- > > > > Glenn Holmer (Linux registered user #16682) > > > > "After the vintage season came the aftermath -- and Cenbe." > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: > [email protected] > > > > For additional commands, e-mail: > > [email protected] > > > > > > > > For further information about the NetBeans mailing lists, visit: > > > > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > > > > > > > > > > > > > > > > > > > -- > > Regards, > > Carl > > > -- Regards, Carl
