Thanks everyone for taking the time to look into this. Answers below but there is a big caveat. On Mon, Nov 26, 2018 at 3:54 PM Emilian Bold <[email protected]> wrote: > Peter, is it OK to consider your binaries under the Apache license for > redistribution? On the github repo where the binaries are, I also checked in the source for the changes plus the updated build script. So anyone with the source and the Microsoft C compiler (v19) should be able to reproduce the build. In terms of using the actual binaries, that's fine by me. > So, just to confirm, does profiling still work with Java 8? Yes, I checked it was still working with openjdk 1.8.
The problem with this 'quick fix' is that it relies on an assumption about the JVM which is not guaranteed to be correct, specifically the values that jmethodid, a JNI type, can take. I have asked for some guidance on this from the JDK mailing list, see: http://mail.openjdk.java.net/pipermail/discuss/2018-November/004916.html (sorry about all these multiple sources of information!) In short - what we have now seems to work but I'd like to request more time to fix this properly. Once I've done this I would appreciate a bit of help from Windows and non-Windows users to check it's working correctly. Thanks, Peter --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
