Peter, Will your fix be included in the release of NB 10?
Cheers JM On Fri, Nov 16, 2018 at 11:08 AM Peter Hull <[email protected]> wrote: > On Thu, Nov 15, 2018 at 6:02 AM Emilian Bold <[email protected]> > wrote: > > PS: @Peter: if you could also make a recompiled .DLL available > > together with the branch it would be great. > Right, I have put changes into a fork here: > https://github.com/pedro-w/incubator-netbeans/tree/profiler-tmp > and the binaries (just the native code dll) > https://github.com/pedro-w/incubator-netbeans/releases/tag/v0.1-alpha > > I have tested it and it seems to be working on Windows 64. I've tested > it compiles on Windows 32. I have not tested or looked at any other > platform (though I don't think my changes should cause problems) > > I speculate the problem was some incorrect casting (can't cast a 64 > bit pointer to long on Windows?) which maybe didn't manifest on > previous JDKs because the values of jmethodid. > I don't know enough about the internals of the JVM but I'm still not > sure if the method used to convert a jmethodid to a jint is robust > going forward. > > Please let me know what you think, > Pete > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > For further information about the NetBeans mailing lists, visit: > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > >
