Hey Jaroslav, I have a Question About this test here: https://builds.apache.org/job/incubator-netbeans-jsparser/6/testReport/org.netbeans.modules.javascript2.editor/JsCodeCompletionES6Test/testClassName01/
Does that mean, that graal can’t handle ES6 atm or do I understand smth wrong? Because the expected result should be „CLASS“ but the completion says it is „VARIABLE“. Can you help me here to understand that? Cheers Chris Von: Jaroslav Tulach Gesendet: Dienstag, 29. Januar 2019 15:33 An: Apache NetBeans Betreff: Re: Help, JavaScript fans! was: Use Graal.js (parser) for NetBeans 11 Hail JavaScript! One of the common questions is how many of those more than six hundred failures are related to switch of the parser from Nashorn to Graal.js. To answer that question I have set another job up: https://builds.apache.org/job/incubator-netbeans-jsparser-tests/ it does the same test as https://builds.apache.org/job/incubator-netbeans-jsparser/ <https://builds.apache.org/job/incubator-netbeans-jsparser/lastCompletedBuild/testReport/org.netbeans.modules.javascript2.sdoc/SDocCompletionDocumentationTest/testCompletionDocumentation01/> but it takes the sources from master branch. There seems to be 129 failures in the master branch. That is a lot and it would be nice to fix them, but... It means that there is more than five hundred failures that are somehow related to the parser change. I assume that means the branch isn't in mergable state right now. Your help is needed! Fix a test! Make NetBeans better! -jt pá 25. 1. 2019 v 19:38 odesílatel Geertjan Wielenga <[email protected]> napsal: > Investigated the ones starting with this one (there are 11 others) but > couldn't figure it out: > > > https://builds.apache.org/job/incubator-netbeans-jsparser/lastCompletedBuild/testReport/org.netbeans.modules.javascript2.sdoc/SDocCompletionDocumentationTest/testCompletionDocumentation01/ > > Gj > > On Fri, Jan 25, 2019 at 3:59 PM Geertjan Wielenga < > [email protected]> wrote: > > > Would it be true to say that the majority, or at least many, of these > > failing tests were already failing before the introduction of the > Graal.js > > parser? > > > > Gj > > > > > > On Fri, Jan 25, 2019 at 3:50 PM Geertjan Wielenga < > > [email protected]> wrote: > > > >> Well, that issue probably doesn't make sense since we're checking in > >> directly into Svata's repo, right? > >> > >> Anyway, let me know if this makes sense, if not, tell me how to do it > >> differently: > >> > >> > >> > https://github.com/sdedic/incubator-netbeans/commit/908659392359671f7166566294b20c14e8d71232 > >> > >> Gj > >> > >> > >> On Fri, Jan 25, 2019 at 2:51 PM Geertjan Wielenga < > >> [email protected]> wrote: > >> > >>> Not sure if there is an issue yet for fixing the failing tests, created > >>> it and will be referencing this in my pull requests: > >>> > >>> https://issues.apache.org/jira/browse/NETBEANS-1990 > >>> > >>> Gj > >>> > >>> > >>> On Fri, Jan 25, 2019 at 2:37 PM Christian Lenz <[email protected] > > > >>> wrote: > >>> > >>>> Will try to help on the weekend. Maybe. > >>>> > >>>> > >>>> Cheers > >>>> > >>>> Chris > >>>> > >>>> > >>>> > >>>> Von: Jaroslav Tulach > >>>> Gesendet: Freitag, 25. Januar 2019 13:18 > >>>> An: Apache NetBeans > >>>> Cc: Svata Dedic > >>>> Betreff: Help, JavaScript fans! was: Use Graal.js (parser) for > NetBeans > >>>> 11 > >>>> > >>>> I assume there is a lot of people interested in support of modern > >>>> JavaScript, right? We need you help: > >>>> > >>>> čt 24. 1. 2019 v 5:59 odesílatel Jaroslav Tulach < > >>>> [email protected]> > >>>> napsal: > >>>> > > >>>> > The PR-1011 is in. > >>>> > > >>>> > Somebody needs to start working on rewriting the `webcommon/ > >>>> > javascript2.editor/` to use the parser in `webcommon.libs.graaljs`. > >>>> > >>>> > >>>> > >>>> Sváťa created a PR: > >>>> https://github.com/apache/incubator-netbeans/pull/1099, > >>>> but it cannot be merged until the code is rewritten to use the new > >>>> version > >>>> of the parser and work correctly. There is a Jenkins job that tracks > the > >>>> status: > >>>> > >>>> https://builds.apache.org/job/incubator-netbeans-jsparser/ > >>>> > >>>> Right now we have 693 failures. Please help us fix them. The > >>>> instructions > >>>> are given in the job description, and it should be fairly easy. Get > the > >>>> repository: > >>>> > >>>> git clone https://github.com/sdedic/incubator-netbeans.git > >>>> cd incubator-netbeans > >>>> git checkout experimental/graaljs_parser > >>>> > >>>> and then build it all and check the tests: > >>>> > >>>> ant build > >>>> for i in webcommon/*; do > >>>> (cd $i; ant test-unit -Dcontinue.after.failing.tests=true) > >>>> done > >>>> > >>>> You can open any module under webcommon in the NetBeans IDE, select a > >>>> test > >>>> and run or debug it. > >>>> > >>>> If you care about JavaScript, please help: Fix a test. Make NetBeans > >>>> better! > >>>> -jt > >>>> > >>>> > >>>> > >>>> > Dne neděle 13. ledna 2019 5:24:04 CET, Jaroslav Tulach napsal(a): > >>>> > > Hello Emilian, Matthias & everyone. > >>>> > > > >>>> > > Dne sobota 12. ledna 2019 9:38:53 CET, Emilian Bold napsal(a): > >>>> > > > I see the parser source is here > >>>> > > > > >>>> > > >>>> > https://github.com/graalvm/graaljs/tree/master/graal-js/src/com.oracle.js > >>>> . > >>>> > > > pa rser but it's not compiled as an independent JAR available in > >>>> Maven > >>>> > > > Central. Could the GraalVM project do this? > >>>> > > > > >>>> > > > The whole org.graalvm.js:js seems pretty big and has many > >>>> > > > dependencies. We just need the parser. > >>>> > > > >>>> > > Let's consider this in the context of 371465581f2011 and PR-1011 > and > >>>> > > NETBEANS-1009. > >>>> > > > >>>> > > #1 - Nashorn isn't the future of JavaScript engines on JDK. We > will > >>>> need > >>>> > > another engine anyway in the future. > >>>> > > > >>>> > > #2 - Emilian commented in PR-1011 that using Graal.js from > >>>> bootclasspath > >>>> > > isn't appropriate > >>>> > > > >>>> > > #3 - We need parts of Graal.js anyway for the editing support > >>>> > > > >>>> > > #4 - OracleLabs (my employer) supports wider use of Graal.js > >>>> > > > >>>> > > When I look at the parser issue from a broader perspective, I > >>>> propose to: > >>>> > > > >>>> > > * modify PR-1011 to bundle whole Graal.js and necessary libraries > >>>> > > > >>>> > > that will solve #1, #2, #4. Then we need another PR to modify the > >>>> > JavaScript > >>>> > > editing infrastructure to use the new version of the Graal.js > >>>> parser. I > >>>> > was > >>>> > > hoping Svatopluk Dědic could take care of that, but as he is busy > >>>> with > >>>> > > other tasks, help from community would be more than welcomed. > Anyone > >>>> > > interested in supporting EcmaScript7 features (syntax of which the > >>>> newest > >>>> > > version of Graal.js handles) in NetBeans? > >>>> > > > >>>> > > I'll work on modifying the PR-1011 to include Graal.js as a > library > >>>> on > >>>> > > Monday, next week. > >>>> > > -jt > >>>> > > >>>> > > >>>> > > >>>> > > >>>> > > >>>> > > --------------------------------------------------------------------- > >>>> > To unsubscribe, e-mail: > [email protected] > >>>> > For additional commands, e-mail: > >>>> [email protected] > >>>> > > >>>> > For further information about the NetBeans mailing lists, visit: > >>>> > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > >>>> > > >>>> > > >>>> > > >>>> > > >>>> > >>>> >
