Mark, I don't think there is a strong preference for patches vs. pull requests. A lot of contributors use pull requests, and I personally find it easier to review pull requests because you can give feedback in-line on the code. The more important thing is that whatever is being submitted should always tie back to a JIRA, and commit messages should start with the JIRA name.
-Bryan On Tue, Oct 27, 2015 at 6:02 AM, Oleg Zhurakousky < [email protected]> wrote: > Mark > > The following output comes from RunNifi which starts org.apache.nifi.NiFi > as a separate JVM process which means you are not really in full DEBUG mode > anyway: > > opt/java/jdk1.7.0_75/bin/java > > -Dnifi.properties.file.path=/home/mpetronic/nifi-0.3.1-SNAPSHOT/./conf/nifi.properties > -Dfile.encoding=ANSI_X3.4-1968 -classpath > > /home/mpetronic/repos/nifi-ide-integration/bin:/home/mpetronic/.m2/repository/org/apache/nifi/nifi-api/0.3.1-SNAPSHOT/nifi-api-0.3.1-SNAPSHOT.jar:/home/mpetronic/.m2/repository/org/apache/nifi/nifi-runtime/0.3.1-SNAPSHOT/nifi-runtime-0.3.1-SNAPSHOT.jar:/home/mpetronic/.gradle/caches/modules-2/files-2.1/org.apache.logging.log4j/log4j-core/2.4/d99532ba3603f27bebf4cdd3653feb0e0b84cf6/log4j-core-2.4.jar:/home/mpetronic/.gradle/caches/modules-2/files-2.1/org.slf4j/slf4j-api/1.7.12/8e20852d05222dc286bf1c71d78d0531e177c317/slf4j-api-1.7.12.jar:/home/mpetronic/.gradle/caches/modules-2/files-2.1/org.slf4j/slf4j-log4j12/1.7.12/485f77901840cf4e8bf852f2abb9b723eb8ec29/slf4j-log4j12-1.7.12.jar:/home/mpetronic/.gradle/caches/modules-2/files-2.1/org.slf4j/jul-to-slf4j/1.7.12/8811e2e9ab9055e557598dc9aedc64fd43e0ab20/jul-to-slf4j-1.7.12.jar:/home/mpetronic/.m2/repository/org/apache/nifi/nifi-nar-utils/0.3.1-SNAPSHOT/nifi-nar-utils-0.3.1-SNAPSHOT.jar:/home/mpetronic/.m2/repository/org/apache/nifi/nifi-properties/0.3.1-SNAPSHOT/nifi-properties-0.3.1-SNAPSHOT.jar:/home/mpetronic/.m2/repository/org/apache/nifi/nifi-documentation/0.3.1-SNAPSHOT/nifi-documentation-0.3.1-SNAPSHOT.jar:/home/mpetronic/.gradle/caches/modules-2/files-2.1/org.apache.logging.log4j/log4j-api/2.4/cc68e72d6d14098ba044123e10e048d203d3fd47/log4j-api-2.4.jar:/home/mpetronic/.gradle/caches/modules-2/files-2.1/log4j/log4j/1.2.17/5af35056b4d257e4b64b9e8069c0746e8b08629f/log4j-1.2.17.jar:/home/mpetronic/nifi-0.3.1-SNAPSHOT/conf > org.apache.nifi.NiFi > > If you are in Eclipse, did you go through Run Configuration step where you > configure your man class that should be org.apache.nifi.NiFi? > > Oleg > > > On Oct 27, 2015, at 8:55 AM, Mark Petronic <[email protected]> > wrote: > > > > Main Class is definitely configured to org.apache.nifi.NiFi per > > instructions. That's what I see in the sample command lines I sent > > you, too. Curious, what makes you think that was misconfigured? > > > > On Tue, Oct 27, 2015 at 8:52 AM, Oleg Zhurakousky > > <[email protected]> wrote: > >> It appears you’ve misconfigured your Run Configuration. > >> It seems like your MainClass is org.apache.nifi.bootstrap.RunNifi. It > should be org.apache.nifi.NiFi > >> > >> Can you verify? > >> > >> Oleg > >> > >>> On Oct 27, 2015, at 8:45 AM, Mark Petronic <[email protected]> > wrote: > >>> > >>> On Tue, Oct 27, 2015 at 6:55 AM, Oleg Zhurakousky > >>> <[email protected]> wrote: > >>>> I was just able to reproduce your exact error by disassociating it > from the class path > >>> > >>> Oleg, thanks for the response. > >>> > >>> 1. I verified that my working directory is correct and points to my > >>> running version of Nifi: > >>> > >>> /home/mpetronic/nifi-0.3.1-SNAPSHOT > >>> > >>> 2. I verified that src/main/resources is indeed the one and only entry > >>> listing in my build path settings under the "Source" tab. However, I > >>> don't see that reflected in the below command line. > >>> > >>> 3. Not sure how to dump the active classpath from Eclipse project > >>> configuration but, if I run Nifi under Eclipse and go to the > >>> properties of the running instance I see this as the command line used > >>> to run it. Question is why are all my classpaths pointing to files in > >>> the maven repository? Those are the values reflected in the project > >>> build path under the "Libraries" tab that I got by default after > >>> importing the nifi-ide-integration project. I did not edit anything > >>> there. > >>> > >>> /opt/java/jdk1.7.0_75/bin/java > >>> > -Dnifi.properties.file.path=/home/mpetronic/nifi-0.3.1-SNAPSHOT/./conf/nifi.properties > >>> -Dfile.encoding=ANSI_X3.4-1968 -classpath > >>> > /home/mpetronic/repos/nifi-ide-integration/bin:/home/mpetronic/.m2/repository/org/apache/nifi/nifi-api/0.3.1-SNAPSHOT/nifi-api-0.3.1-SNAPSHOT.jar:/home/mpetronic/.m2/repository/org/apache/nifi/nifi-runtime/0.3.1-SNAPSHOT/nifi-runtime-0.3.1-SNAPSHOT.jar:/home/mpetronic/.gradle/caches/modules-2/files-2.1/org.apache.logging.log4j/log4j-core/2.4/d99532ba3603f27bebf4cdd3653feb0e0b84cf6/log4j-core-2.4.jar:/home/mpetronic/.gradle/caches/modules-2/files-2.1/org.slf4j/slf4j-api/1.7.12/8e20852d05222dc286bf1c71d78d0531e177c317/slf4j-api-1.7.12.jar:/home/mpetronic/.gradle/caches/modules-2/files-2.1/org.slf4j/slf4j-log4j12/1.7.12/485f77901840cf4e8bf852f2abb9b723eb8ec29/slf4j-log4j12-1.7.12.jar:/home/mpetronic/.gradle/caches/modules-2/files-2.1/org.slf4j/jul-to-slf4j/1.7.12/8811e2e9ab9055e557598dc9aedc64fd43e0ab20/jul-to-slf4j-1.7.12.jar:/home/mpetronic/.m2/repository/org/apache/nifi/nifi-nar-utils/0.3.1-SNAPSHOT/nifi-nar-utils-0.3.1-SNAPSHOT.jar:/home/mpetronic/.m2/repository/org/apache/nifi/nifi-properties/0.3.1-SNAPSHOT/nifi-properties-0.3.1-SNAPSHOT.jar:/home/mpetronic/.m2/repository/org/apache/nifi/nifi-documentation/0.3.1-SNAPSHOT/nifi-documentation-0.3.1-SNAPSHOT.jar:/home/mpetronic/.gradle/caches/modules-2/files-2.1/org.apache.logging.log4j/log4j-api/2.4/cc68e72d6d14098ba044123e10e048d203d3fd47/log4j-api-2.4.jar:/home/mpetronic/.gradle/caches/modules-2/files-2.1/log4j/log4j/1.2.17/5af35056b4d257e4b64b9e8069c0746e8b08629f/log4j-1.2.17.jar:/home/mpetronic/nifi-0.3.1-SNAPSHOT/conf > >>> org.apache.nifi.NiFi > >>> > >>> 4. I just got it to work by removing "src/main/resources" from the > >>> "Source" tab and added it to the "Libraries" tab using "Add Class > >>> Folder". Now when I run, I see console logging as expected and my new > >>> command line is below (where src/main/resources is now showing up as > >>> the last entry in the path): But why did I need this extra step? > >>> > >>> /opt/java/jdk1.7.0_75/bin/java > >>> > -Dnifi.properties.file.path=/home/mpetronic/nifi-0.3.1-SNAPSHOT/./conf/nifi.properties > >>> -Dfile.encoding=ANSI_X3.4-1968 -classpath > >>> > /home/mpetronic/.m2/repository/org/apache/nifi/nifi-api/0.3.1-SNAPSHOT/nifi-api-0.3.1-SNAPSHOT.jar:/home/mpetronic/.m2/repository/org/apache/nifi/nifi-runtime/0.3.1-SNAPSHOT/nifi-runtime-0.3.1-SNAPSHOT.jar:/home/mpetronic/.gradle/caches/modules-2/files-2.1/org.apache.logging.log4j/log4j-core/2.4/d99532ba3603f27bebf4cdd3653feb0e0b84cf6/log4j-core-2.4.jar:/home/mpetronic/.gradle/caches/modules-2/files-2.1/org.slf4j/slf4j-api/1.7.12/8e20852d05222dc286bf1c71d78d0531e177c317/slf4j-api-1.7.12.jar:/home/mpetronic/.gradle/caches/modules-2/files-2.1/org.slf4j/slf4j-log4j12/1.7.12/485f77901840cf4e8bf852f2abb9b723eb8ec29/slf4j-log4j12-1.7.12.jar:/home/mpetronic/.gradle/caches/modules-2/files-2.1/org.slf4j/jul-to-slf4j/1.7.12/8811e2e9ab9055e557598dc9aedc64fd43e0ab20/jul-to-slf4j-1.7.12.jar:/home/mpetronic/.m2/repository/org/apache/nifi/nifi-nar-utils/0.3.1-SNAPSHOT/nifi-nar-utils-0.3.1-SNAPSHOT.jar:/home/mpetronic/.m2/repository/org/apache/nifi/nifi-properties/0.3.1-SNAPSHOT/nifi-properties-0.3.1-SNAPSHOT.jar:/home/mpetronic/.m2/repository/org/apache/nifi/nifi-documentation/0.3.1-SNAPSHOT/nifi-documentation-0.3.1-SNAPSHOT.jar:/home/mpetronic/.gradle/caches/modules-2/files-2.1/org.apache.logging.log4j/log4j-api/2.4/cc68e72d6d14098ba044123e10e048d203d3fd47/log4j-api-2.4.jar:/home/mpetronic/.gradle/caches/modules-2/files-2.1/log4j/log4j/1.2.17/5af35056b4d257e4b64b9e8069c0746e8b08629f/log4j-1.2.17.jar:/home/mpetronic/repos/nifi-ide-integration/src/main/resources > >>> org.apache.nifi.NiFi > >>> > >>> May I ask you a related question about environment setup for > >>> contributing given I am new to contributing and want to get this > >>> right? > >>> > >>> I read the contributors/developers guides. They talk about three > >>> repos: the ASF repo, the github mirror, and a personal forked github > >>> repo. They talk about two way to commit: patch and pull request. > >>> > >>> 1. Is there any difference in choosing to use the ASF vs. github > >>> mirror as my primary upstream tracking repo? > >>> > >>> 2. I am leaning toward forking the github mirror and using the forked > >>> repo from my development so that I can submit using pull requests. > >>> What do you advise? > >>> > >>> Thanks again for all your help... > >>> > >> > > > >
