Github user olegz commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/123#discussion_r44872287
  
    --- Diff: 
nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/lucene/DocsReader.java
 ---
    @@ -47,9 +46,6 @@
     public class DocsReader {
         private final Logger logger = 
LoggerFactory.getLogger(DocsReader.class);
     
    -    public DocsReader(final List<File> storageDirectories) {
    -    }
    -
    --- End diff --
    
    Considering that this class does not appear to be intended as public API I 
still believe it is the right thing to do since the constructor argument isn't 
used. 
    In fact, need to look if we can make this class package private.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to