Github user trkurc commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/123#discussion_r44872910
  
    --- Diff: 
nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/lucene/DocsReader.java
 ---
    @@ -47,9 +46,6 @@
     public class DocsReader {
         private final Logger logger = 
LoggerFactory.getLogger(DocsReader.class);
     
    -    public DocsReader(final List<File> storageDirectories) {
    -    }
    -
    --- End diff --
    
    I'm like 95% with @olegz  on this. I believe it is implausible that someone 
would be calling this method and likely needed a comment that it was public for 
some other reason than it was a public API. That 5% not with @olegz is adding 
deprecation tag adds a tiny smidge of tech debt, which would be swept up when 
we investigate all the deprecated methods for 1.0.0 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to