Github user joewitt commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/123#discussion_r44873162
  
    --- Diff: 
nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/lucene/DocsReader.java
 ---
    @@ -47,9 +46,6 @@
     public class DocsReader {
         private final Logger logger = 
LoggerFactory.getLogger(DocsReader.class);
     
    -    public DocsReader(final List<File> storageDirectories) {
    -    }
    -
    --- End diff --
    
    We have designed flexibility in for a reason.  Deprecation is appropriate 
for the public portions of code designed for extension and/or modification.  
For everything else let's be sure it is clear and documented what is fair game 
for the community to evolve.  If it isn't clear then we should err on the side 
of deprecation then make it clear.  We need to have agility behind the curtain.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to