Github user aldrinpiri commented on a diff in the pull request:
https://github.com/apache/nifi/pull/164#discussion_r49289489
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/pom.xml ---
@@ -206,6 +206,11 @@ language governing permissions and limitations under
the License. -->
<scope>test</scope>
</dependency>
<dependency>
+ <groupId>org.xerial.snappy</groupId>
+ <artifactId>snappy-java</artifactId>
--- End diff --
Doing a cursory scan, everything looks pretty good, although I notice that
this dependency was not added into the NOTICE file. Would imagine that would
be needed, but am certainly not the licensing expert.
@joewitt NOTICE sufficient, or does this need to be elsewhere as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
