Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/124#discussion_r49480617
--- Diff:
nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/AbstractHTMLProcessor.java
---
@@ -0,0 +1,120 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi;
+
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.processor.AbstractProcessor;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.io.InputStreamCallback;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.jsoup.Jsoup;
+import org.jsoup.nodes.Document;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.util.concurrent.atomic.AtomicReference;
+
+public abstract class AbstractHTMLProcessor extends AbstractProcessor {
+
+ protected static final String ELEMENT_HTML = "HTML";
+ protected static final String ELEMENT_TEXT = "Text";
+ protected static final String ELEMENT_DATA = "Data";
+ protected static final String ELEMENT_ATTRIBUTE = "Attribute";
+
+ public static final PropertyDescriptor URL = new PropertyDescriptor
+ .Builder().name("URL")
+ .description("Base URL for the HTML page being parsed.")
+ .required(true)
+ .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+ .build();
+
+ public static final PropertyDescriptor CSS_SELECTOR = new
PropertyDescriptor
+ .Builder().name("CSS Selector")
+ .description("CSS selector syntax string used to extract the
desired HTML element(s).")
+ .required(true)
+ .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
--- End diff --
Should consider a custom validator here, that verifies that the CSS
Selector can be parsed appropriately by the library. This way, if the user
enters something invalid, it is shown as a validation problem instead of
letting them run the processor and find out after it runs that it's not right.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
