Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/124#issuecomment-170978164
@jdye64 I left a lot of inline comments while doing a code review. Mostly
just pointing out either naming conventions that we should strive to be
consistent with, or pointing out some utils/convenience methods that will help
to keep the code clean.
Overall, I think it's an awesome contribution! Thanks for putting in all of
the effort to get this going. Code looks great overall - excellent unit tests
to verify behavior. Very cool stuff!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
