Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/124#issuecomment-173351611
Jeremy,
I've been reviewing this and I made a handful of minor changes:
* Copied licensing information to the nar - it was already present in
nifi-assembly. Just had to create a LICENSE file for the nar itself.
* Updated version from 0.4.0-SNAPSHOT to 0.4.2-SNAPSHOT
* Improved error handling (if we hit any RuntimeException, such as the
Content Repository is out of disk space, it was routing to the "invalid html"
relationship)
* Updated some code to match the nifi style a bit more (adding 'final'
keywords, using longer max line width (200 chars is the max we use with nifi))
I did not change the logic of any of the Processors, though. All very solid
stuff.
Excited to see this getting into NiFi! Thanks for all of the work that
you've put into this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
