Github user alopresto commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/246#discussion_r54322948
  
    --- Diff: 
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/PutS3Object.java
 ---
    @@ -177,10 +179,19 @@
                 .addValidator(StandardValidators.TIME_PERIOD_VALIDATOR)
                 .build();
     
    +    public static final PropertyDescriptor SERVER_SIDE_ENCRYPTION = new 
PropertyDescriptor.Builder()
    +            .name("Server Side Encryption")
    --- End diff --
    
    `.name()` should be used to set a unique name (in the form 
`"server-side-encryption"`). `.displayName()` can be used for a human-readable 
form as above. 
    
    ```java
     public static final PropertyDescriptor SERVER_SIDE_ENCRYPTION = new 
PropertyDescriptor.Builder()
                .name("server-side-encryption")
                .displayName("Server Side Encryption")
                .description("Specifies the algorithm used for server side 
encryption.")
                .required(true)
                .allowableValues(NO_SERVER_SIDE_ENCRYPTION, 
ObjectMetadata.AES_256_SERVER_SIDE_ENCRYPTION)
                .defaultValue(NO_SERVER_SIDE_ENCRYPTION)
                .build();
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to