Github user adamonduty commented on a diff in the pull request:
https://github.com/apache/nifi/pull/246#discussion_r54327468
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/PutS3Object.java
---
@@ -177,10 +179,19 @@
.addValidator(StandardValidators.TIME_PERIOD_VALIDATOR)
.build();
+ public static final PropertyDescriptor SERVER_SIDE_ENCRYPTION = new
PropertyDescriptor.Builder()
+ .name("Server Side Encryption")
--- End diff --
That makes sense, but there are also 6 instances above this code that
doesn't follow the same rule. Which is best: match the existing style, or match
the rule?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---