Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi/pull/213#discussion_r56212428
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/kinesis/firehose/AbstractKinesisFirehoseProcessor.java
---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.aws.kinesis.firehose;
+
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.util.StandardValidators;
+import
org.apache.nifi.processors.aws.AbstractAWSCredentialsProviderProcessor;
+
+import com.amazonaws.ClientConfiguration;
+import com.amazonaws.auth.AWSCredentials;
+import com.amazonaws.auth.AWSCredentialsProvider;
+import com.amazonaws.services.kinesisfirehose.AmazonKinesisFirehoseClient;
+
+/**
+ * This class provides processor the base class for kinesis firehose
+ */
+public abstract class AbstractKinesisFirehoseProcessor extends
AbstractAWSCredentialsProviderProcessor<AmazonKinesisFirehoseClient> {
+
+ public static final PropertyDescriptor
KINESIS_FIREHOSE_DELIVERY_STREAM_NAME = new PropertyDescriptor.Builder()
+ .name("Amazon Kinesis Firehose Delivery Stream Name")
+ .description("The name of kinesis firehose delivery stream")
+ .expressionLanguageSupported(false)
+ .required(true)
+ .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+ .build();
+
+ public static final PropertyDescriptor BATCH_SIZE = new
PropertyDescriptor.Builder()
+ .name("Batch Size")
+ .description("Batch size for messages (1-500).")
+ .defaultValue("250")
+ .required(false)
+ .addValidator(StandardValidators.createLongValidator(1, 500,
true))
+ .sensitive(false)
+ .build();
+
+ public static final PropertyDescriptor MAX_MESSAGE_BUFFER_SIZE_MB =
new PropertyDescriptor.Builder()
+ .name("Max message buffer size (MB)")
+ .description("Max message buffer size (1-50) MB")
+ .defaultValue("1")
+ .required(false)
+ .addValidator(StandardValidators.createLongValidator(1, 50,
true))
--- End diff --
Likely want to prefer utilization of the DATA_SIZE_VALIDATOR. Not sure we
need to strictly cap this as we are guiding users toward an appropriate path
and if they have conditions where they wish to go above the maximum (as well as
supporting hardware) that should be fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
