Github user mans2singh commented on the pull request:
https://github.com/apache/nifi/pull/239#issuecomment-222020291
Hi @jvwing -
Thanks for your feedback.
Regarding changing the hierarchy to create a `AmazonWebServiceClient`
independent base class - I can create separate KPL/KCL based processors but
then I will not able to reuse some of the properties, methods available in the
Nifi's AWS base classes. Also, there is are `AmazonWebServiceClient` based
Kinesis consumer and producer just like for S3, SNS, SQS, etc but as you've
also pointed out we loose the advantages of automatic recovery, batching,
monitoring, load balancing across shards etc provided by the KCL/KPL libraries.
I also think (this is just MHO), that maybe other event driven services
(SQS,SNS, etc) can benefit from the KCL/KPL model. Let me know if using the
re-implementing KCL/KPL based processors independent of the current processor
(ie, without changing the base classes) is a better choice.
I can change the names, document permissions required for dynamodb,
cloudwatch, etc, and add more unit tests as you've recommended.
Please let me know if you have any other suggestions.
Thanks again for your comments/advice.
Mans
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
