[GitHub] nifi pull request: Nifi 1540 - AWS Kinesis Get and Put Processors

[mans2singh]

Github user mans2singh commented on the pull request:

    https://github.com/apache/nifi/pull/239#issuecomment-222191326
  
    Hi @jvwing 
    
    Thanks again for your comments:
    
    I have am currently not using REL_FAILURE in GetKinesis as you've 
mentioned, and wanted your advice on the failure scenarios in GetKinesis:
    
    In the GetKinesis.java (lines 196 - 199):
    
    {code:GetKinesis.java}
     } catch (Exception e) {
                if ( flowFile != null ) {
                    session.remove(flowFile);
                }
    {code:GetKinesis.java}
    
    I am not sure if an exception is throw, should I just remove the flowfile 
from the session, or should it be transferred to REL_FAILURE or both ? 
    
    Please let me know your recommendations.
    
    Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---