[GitHub] nifi issue #239: Nifi 1540 - AWS Kinesis Get and Put Processors

[mans2singh]

Github user mans2singh commented on the issue:

    https://github.com/apache/nifi/pull/239
  
    Hi @jvwing:  
    
    Regarding exception handling - Kinesis will automatically handle retrying 
if there is kinesis client error from the last checkpoint created in the 
GetKinesisStream.  
    
    In case of exceptions while handling a record inside the GetKinesisStream 
(line 220)
    
    {code:GetKinesisStream.java}
    catch (Exception e) {
               if ( flowFile != null ) {
                    session.remove(flowFile);
                }
                getLogger().error("Error while handling record: " + 
e.getMessage());
     } 
    {code}
    
    I was thinking instead of just removing the FlowFile, I should pass the 
flowFile to failure relationship, and include it among the checkpoint record so 
that user can handle it separately and we won't get into a loop where the bad 
flow file will be reprocessed.
    
    Let me know what you recommend.
    
    Thanks
    
    Mans
    
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---