Github user mans2singh commented on the issue:

    https://github.com/apache/nifi/pull/239
  
    Hey @jvwing 
    
    I've made the property name changes you recommended and corrected 
maxBufferedTimeInterval - it was indeed millis and values were different from 
what I had.  I've also added allowable values from boolean where I missed them.
    
    Regarding units (using KB instead of bytes and seconds instead of millis) - 
I found that some values were not exactly in kb or seconds (eg: in producer max 
buffered interval case there was 100-9223372036854775807 millis value). This 
made creates a one to one mapping to AWS code.  But let me know what you 
recommend.
    
    I am not quite sure of the your #1 comment (Use name as a key and 
displayName for the UI text, rather than just name.).  Let me know what you 
recommend and I will work on it.
    
    Regarding property - KINESIS_PRODUCER_FAIL_IF_THROTTLED - If set to true, 
the producer will not retry in case of throttling error.  
KINESIS_CONSUMER_DEFAULT_DONT_CALL_PROCESS_RECORDS_FOR_EMPTY_RECORD_LIST - will 
avoid calling the producer if the records list is empty perhaps for performance 
reasons.  These properties were available and I wanted to make sure they are 
all exposed so that the client can use them at their discretion.
    
    Regarding the issue of producer errors, these are known issues and I am 
including links from what I could find about them:
    #1 - EOF file issue - 
https://github.com/awslabs/amazon-kinesis-producer/issues/46
    #2 - Code 137 is a fatal error signal 
    #3 - Child process has been shutdown is also producer issue - 
https://github.com/awslabs/amazon-kinesis-producer/issues/39
    
    If you have more details/stacktrace about the above, let me know and I will 
try to investigate it further.
    
    Please let me know if I have missed anything.
    
    Thanks again for your detailed review/comments.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to